account for more booleans

AD7six · Feb 4, 2014 · 3b7ead6 · 3b7ead6
1 parent 39c20a3
commit 3b7ead6
Show file tree

Hide file tree

Showing 3 changed files with 52 additions and 3 deletions.
diff --git a/src/Wrapper/CakePHP/EmailDsn.php b/src/Wrapper/CakePHP/EmailDsn.php
@@ -55,6 +55,10 @@ public function getMessageId()
             return;
         }
 
+        if (strlen($return) > 1) {
+            return $return;
+        }
+
         return (bool) $return;
     }
 

diff --git a/src/Wrapper/CakePHP/LogDsn.php b/src/Wrapper/CakePHP/LogDsn.php
@@ -23,9 +23,34 @@ public static function parse($url, $options = [])
         return $inst->toArray();
     }
 
-    public function getTypes()
+    public function getGroups()
+    {
+        $return = $this->dsn->groups;
+
+        if ($return === null) {
+            return;
+        }
+        return explode(',', $return);
+    }
+
+    public function getLock()
     {
-        return explode(',', $this->dsn->types);
+        $return = $this->dsn->lock;
+
+        if ($return === null) {
+            return;
+        }
+        return (int) $return;
+    }
+
+    public function getProbability()
+    {
+        $return = $this->dsn->probability;
+
+        if ($return === null) {
+            return;
+        }
+        return (int) $return;
     }
 
     public function getScheme()
@@ -42,4 +67,24 @@ public function setScheme($value)
     {
         $this->dsn->scheme = lcfirst($value);
     }
+
+    public function getSerialize()
+    {
+        $return = $this->dsn->serialize;
+
+        if ($return === null) {
+            return;
+        }
+        return (int) $return;
+    }
+
+    public function getTypes()
+    {
+        $return = $this->dsn->types;
+
+        if ($return === null) {
+            return;
+        }
+        return explode(',', $return);
+    }
 }
diff --git a/tests/TestCase/Wrapper/CakePHP/EmailDsnTest.php b/tests/TestCase/Wrapper/CakePHP/EmailDsnTest.php
@@ -60,7 +60,7 @@ public function defaultsProvider()
                 ]
             ],
             [
-                'smtp://user:secret@localhost:25/?from=you@localhost&messageId=true&template=0&layout=0&timeout=30',
+                'smtp://user:secret@localhost:25/?from=you@localhost&messageId=1&template=0&layout=0&timeout=30',
                 [
                     'transport' => 'Smtp',
                     'host' => 'localhost',