Merge pull request #15 from ollietreend/issue-10

Fixes #10 - URL decoding
AD7six · Mar 26, 2015 · 69ff74a · 69ff74a
2 parents 3f33829 + 8f7a4e2
commit 69ff74a
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 1 deletion.
diff --git a/src/Dsn.php b/src/Dsn.php
@@ -239,6 +239,14 @@ protected function parseUrlArray($url)
 
         $url = array_merge($this->uriKeys, $url);
 
+        foreach (['host', 'user', 'pass'] as $key) {
+            if (!isset($url[$key])) {
+                continue;
+            }
+
+            $url[$key] = urldecode($url[$key]);
+        }
+
         foreach ($url as $key => $val) {
             $setter = 'set' . ucfirst($key);
             $this->$setter($val);
@@ -289,6 +297,14 @@ protected function toUrlArray($data)
     {
         $url = array_intersect_key($data, $this->uriKeys);
 
+        foreach (['host', 'user', 'pass'] as $key) {
+            if (!isset($url[$key])) {
+                continue;
+            }
+
+            $url[$key] = urlencode($url[$key]);
+        }
+
         if ($url['adapter']) {
             $return = $url['scheme'] . '+' . $url['adapter'] . '://';
         } else {
@@ -315,7 +331,6 @@ protected function toUrlArray($data)
         if ($query) {
             foreach ($query as $key => &$value) {
                 if (is_array($value)) {
-
                     $intermediate = [];
                     foreach ($value as $k => $v) {
                         $v = urlencode($v);

diff --git a/tests/TestCase/Wrapper/CakePHP/V2/EmailDsnTest.php b/tests/TestCase/Wrapper/CakePHP/V2/EmailDsnTest.php
@@ -73,6 +73,21 @@ public function defaultsProvider()
                     'layout' => false,
                     'timeout' => 30,
                 ]
+            ],
+            [
+                'smtp://user:secret@ssl%3A%2F%2Flocalhost:465/?from=you@localhost&messageId=1&template=0&layout=0&timeout=30',
+                [
+                    'transport' => 'Smtp',
+                    'host' => 'ssl://localhost',
+                    'port' => 465,
+                    'username' => 'user',
+                    'password' => 'secret',
+                    'from' => 'you@localhost',
+                    'messageId' => true,
+                    'template' => false,
+                    'layout' => false,
+                    'timeout' => 30,
+                ]
             ]
         ];
     }

diff --git a/tests/TestCase/Wrapper/CakePHP/V3/EmailDsnTest.php b/tests/TestCase/Wrapper/CakePHP/V3/EmailDsnTest.php
@@ -79,6 +79,21 @@ public function defaultsProvider()
                     'layout' => false,
                     'timeout' => 30,
                 ]
+            ],
+            [
+                'smtp://user:secret@ssl%3A%2F%2Flocalhost:465/?from=you@localhost&messageId=1&template=0&layout=0&timeout=30',
+                [
+                    'className' => 'Smtp',
+                    'host' => 'ssl://localhost',
+                    'port' => 465,
+                    'username' => 'user',
+                    'password' => 'secret',
+                    'from' => 'you@localhost',
+                    'messageId' => true,
+                    'template' => false,
+                    'layout' => false,
+                    'timeout' => 30,
+                ]
             ]
         ];
     }