You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Jason, I believe this is legacy from the two sets of contributors on the ISO plugin. I worked to consolidate things in most places, but in certain places I chose to leave things alone as cohesive, working blocks of code for now. As far as I can tell, the Resolution in the Logged Data export code is equivalent to scale elsewhere. It would be perfectly reasonable to streamline them in my opinion.
GetResolution:
ISOv4Plugin/ISOv4Plugin/Mappers/LoggedDataMappers/Export/NumericValueMapper.cs
Line 45 in d4ce429
ConvertToIsoUnit:
ISOv4Plugin/ISOv4Plugin/ExtensionMethods/ExtensionMethods.cs
Line 177 in d4ce429
Is "ISOUnit.Scale" the same as "_ddis[ddi.GetValueOrDefault()].Resolution"?
The text was updated successfully, but these errors were encountered: