Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the difference between "GetResolution" & "ConvertToIsoUnit"? #30

Open
JasonRoesbeke opened this issue Feb 12, 2018 · 1 comment

Comments

@JasonRoesbeke
Copy link
Contributor

GetResolution:

private double GetResolution(NumericRepresentationValue value)

ConvertToIsoUnit:
public static double ConvertToIsoUnit(this ISOUnit unit, double value)

Is "ISOUnit.Scale" the same as "_ddis[ddi.GetValueOrDefault()].Resolution"?

@knelson-farmbeltnorth
Copy link
Contributor

Jason, I believe this is legacy from the two sets of contributors on the ISO plugin. I worked to consolidate things in most places, but in certain places I chose to leave things alone as cohesive, working blocks of code for now. As far as I can tell, the Resolution in the Logged Data export code is equivalent to scale elsewhere. It would be perfectly reasonable to streamline them in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants