Fix typo and suppress error on db connect. #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way if the connection fails, the failure can be captured and used as intended.
|
To my knowledge, mysqli_real_connect() returns false in case of error, which is checked just below, so I'm not sure why we'd need to suppress errors with |
|
Yes, without the error suppression operator I was unable to get past a warning that it created (I'm using Whoops on my API). I'll break things again to get you the exact error. |
|
@ryanpcmcquen I would appreciate if you could provide a code snippet to reproduce the problem |
|
Sorry, I have to break our database to do it. I'll try to carve out some time this week but have been swamped. |
|
I get a timeout error without ignoring warnings (
|
dregad
pushed a commit
that referenced
this pull request
Nov 25, 2017
This way if the connection fails, the error can be captured and used as intended. Without this, mysqli_real_connect() triggers a PHP warning. Fixes #348
|
Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way if the connection fails, the failure can be captured and used as intended.