Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADODB_Active_Record -> Reload() - Strict standards #75

Closed
bzoks opened this issue Jan 20, 2015 · 0 comments
Closed

ADODB_Active_Record -> Reload() - Strict standards #75

bzoks opened this issue Jan 20, 2015 · 0 comments
Milestone

Comments

@bzoks
Copy link

bzoks commented Jan 20, 2015

Reload() function in ADODB_Active_Record (adodb-active-record.inc.php) throws
Strict Standards: Only variables should be assigned by reference in ... adodb-active-record.inc.php on line 561.
Issue is present also in current master branch on github.

Fix would be change from :

    function Reload()
    {
        $db =& $this->DB(); if (!$db) return false;
        $table =& $this->TableInfo();
        $where = $this->GenWhere($db, $table);
        return($this->Load($where));
    }

to:

    function Reload()
    {
        $db = $this->DB(); if (!$db) return false;
        $table = $this->TableInfo();
        $where = $this->GenWhere($db, $table);
        return($this->Load($where));
    }

We use this fix as local modification for years.

Best regards,
Bostjan

@dregad dregad closed this as completed in cba3f2f Apr 20, 2015
@dregad dregad modified the milestone: v5.20 Jul 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants