Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Deprecated: Creation of dynamic property ADODB2_mysql::$quote is deprecated in adodb.inc.php on line 5790 #907

Closed
mnewnham opened this issue Dec 1, 2022 · 4 comments
Closed

[core] Deprecated: Creation of dynamic property ADODB2_mysql::$quote is deprecated in adodb.inc.php on line 5790 #907

mnewnham opened this issue Dec 1, 2022 · 4 comments
Labels
bug core ADOdb core (library and base classes) PHP8.2 PHP8.2 Compatibility Issues
Milestone
v5.22.5

Comments

@mnewnham
Copy link
Contributor

mnewnham commented Dec 1, 2022

No description provided.

@mnewnham mnewnham added bug core ADOdb core (library and base classes) PHP8.2 PHP8.2 Compatibility Issues labels Dec 1, 2022
@mnewnham mnewnham changed the title [core] Deprecated: Creation of dynamic property ADODB2_mysql::$quote is deprecated in adodb.inc.php on line 5789 [core] Deprecated: Creation of dynamic property ADODB2_mysql::$quote is deprecated in adodb.inc.php on line 5790 Dec 1, 2022
@Bozosoft
Copy link

Bozosoft commented Dec 5, 2022

I also have the "Deprecated" but on line 5789 in PHP 8.2 when creating the database
Deprecated: Creation of dynamic property ADODB2_mysql::$quote is deprecated in /lib/adodb/adodb.inc.php on line 5789
line 5789 == $dict->quote = $conn->nameQuote;

@mnewnham
Copy link
Contributor Author

mnewnham commented Dec 6, 2022

That may have been my mistake reading the numbers off of a vi session!

@Bozosoft
Copy link

Bozosoft commented Dec 6, 2022

In /datadict/datadict-mysql.inc.php line:25: class ADODB2_mysql extends ADODB_DataDict {
so add line 24 #[\AllowDynamicProperties]
My test solved the Deprecated

@dregad dregad added this to the v5.22.5 milestone Jan 19, 2023
@dregad
Copy link
Member

dregad commented Mar 12, 2023

Fixed in 5e41924 (master) / 8e51a88 (5.22.5)

@dregad dregad closed this as completed Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug core ADOdb core (library and base classes) PHP8.2 PHP8.2 Compatibility Issues
Projects
None yet
Milestone
v5.22.5
Development

No branches or pull requests
3 participants
@dregad @Bozosoft @mnewnham