Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Partially-supported callable are deprecated in PHP 8.2 #928

Conversation

raortegar
Copy link
Contributor

According to the PHP 8.2 documentation
"parent::method" callables that are not consistent.
Deprecated Callable Patterns

"parent::method" -> parent::class . "::method"

@mnewnham mnewnham self-requested a review February 26, 2023 00:23
dregad pushed a commit that referenced this pull request Mar 12, 2023
Creation of dynamic property
- ADORecordset_sqlite3::$adodbFetchMode in adodb-sqlite3.inc.php (#911)
- ADOFieldObject::$scale in adodb-sqlite3.inc.php (#912)

Partially-supported callable
- in adodb-pdo-inc.php (#928)

---------

This is a re-do of fa572e9 (PR #921)
with an improved commit message.

Co-authored-by: raortegar <raquel.ortega@moodle.com>
Signed-off-by: Damien Regad <dregad@mantisbt.org>
@dregad dregad added this to the v5.22.5 milestone Mar 12, 2023
@dregad dregad added bug PHP8.2 PHP8.2 Compatibility Issues labels Mar 12, 2023
@dregad dregad closed this Mar 12, 2023
dregad added a commit that referenced this pull request Mar 12, 2023
Cherry picked from commits feadc3d and
5e41924.

# Conflicts:
#	adodb.inc.php

Creation of dynamic property
- ADORecordset_sqlite3::$adodbFetchMode in adodb-sqlite3.inc.php (#911)
- ADOFieldObject::$scale in adodb-sqlite3.inc.php (#912)

Partially-supported callable
- in adodb-pdo-inc.php (#928)
@dregad
Copy link
Member

dregad commented Mar 12, 2023

Fixed in 5e41924 (master) / 8e51a88 (5.22.5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PHP8.2 PHP8.2 Compatibility Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants