oci8: unused $seqField property

[dregad]

I noticed this while working through #926, which was proposing to define the missing property to fix the PHP 8.2 deprecation notice:

ADOdb/drivers/adodb-oci8.inc.php

Lines 322 to 327 in bb87e83

	protected function _insertID($table = '', $column = '')
	{
	if (!$this->seqField)
	return false;

The seqField property is used in the data dictionary, but not referenced anywhere else in the driver.

This was introduced by you in #565, so maybe you'll remember what you were trying to achieve... If not I'd suggest to remove the if statement, as it feels like a mistake.

[mnewnham]

So here is what I was trying to achieve, I think. With oracle, there wasn't really the option to create autoincrement columns the way most other databases do, so what we have instead is the create record trigger that uses a sequence to do an on-insert update of an integer column that puts an incrementing value into the column.

The change I made then was because Johns original code started failing when Oracle allowed column names longer than (I think) 16 columns. I also tried to make the code portable so that if _insertId() was called and there wasn't an auto-increment column in the table, the function just returned immediately instead of doing the whole code flow including the getOne() at the end.

My mistake here was to confuse the code being executed for the dictionary for the stuff in the main system. I would like to have something there but thats clearly not the right approach.

[dregad]

Thanks for your reply. This what I thought but it's good to have confirmation.

To get rid of the PHP 8.2 deprecated warning, I propose to just remove the if statement for now since it's not doing anything useful.

If you want I can open a separate issue to track the need for detection of the auto-numbering sequence, and we can work on finding a proper fix for that later.

[dregad]

If you want I can open a separate issue to track the need for detection of the auto-numbering sequence

Done, see #936

[mnewnham]

Ok thanks for looking at that. I started it but found that I couldn't get an oracle connection up and running at home. I will try to do something as soon as I can but I recognize that it's not ultra-important.