Applied fixes from StyleCI

src/Responses/CakeResponseFactory.php

@@ -1,28 +1,26 @@
 <?php
 namespace ADmad\Glide\Responses;
 
-use Cake\Core\Configure;
 use Cake\Network\Response;
-use Cake\Utility\Hash;
 use League\Flysystem\FilesystemInterface;
 use League\Glide\Responses\ResponseFactoryInterface;
 
 class CakeResponseFactory implements ResponseFactoryInterface
 {
-
     /**
      * Create the response.
      *
      * @param \League\Flysystem\FilesystemInterface $cache The cache file system.
      * @param string $path The cached file path.
+     *
      * @return \Cake\Network\Response The response object.
      */
     public function create(FilesystemInterface $cache, $path)
     {
         $stream = $cache->readStream($path);
 
         $contentType = $cache->getMimetype($path);
-        $contentLength = (string)$cache->getSize($path);
+        $contentLength = (string) $cache->getSize($path);
 
         $response = new Response();
         $response->type($contentType);

src/Routing/Filter/GlideFilter.php

@@ -6,17 +6,16 @@
 use Cake\Routing\DispatcherFilter;
 use Cake\Utility\Hash;
 use Cake\Utility\Security;
-use DateTime;
 use League\Glide\ServerFactory;
 use League\Glide\Signatures\SignatureFactory;
 
 class GlideFilter extends DispatcherFilter
 {
-
     /**
      * Callback for Routing.beforeDispatch event.
      *
      * @param \Cake\Event\Event $event The event instance.
+     *
      * @return \Cake\Network\Response Response instance.
      */
     public function beforeDispatch(Event $event)
@@ -47,7 +46,7 @@ public function beforeDispatch(Event $event)
             $response = $server->getImageResponse($path, $request->query);
         }
 
-        $headers = Hash::filter((array)Configure::read('Glide.headers'));
+        $headers = Hash::filter((array) Configure::read('Glide.headers'));
         foreach ($headers as $key => $value) {
             $response->header($key, $value);
         }

src/View/Helper/GlideHelper.php

@@ -8,7 +8,6 @@
 
 class GlideHelper extends Helper
 {
-
     /**
      * Helpers used by this helper.
      *
@@ -29,7 +28,9 @@ class GlideHelper extends Helper
      * @param string $path Image path.
      * @param array $params Image manipulation parameters.
      * @param array $options Array of HTML attributes for image tag.
+     *
      * @return string Complete <img> tag.
+     *
      * @see http://glide.thephpleague.com/1.0/api/quick-reference/
      */
     public function image($path, array $params = [], array $options = [])
@@ -42,7 +43,9 @@ public function image($path, array $params = [], array $options = [])
      *
      * @param string $path Image path.
      * @param array $params Image manipulation parameters.
+     *
      * @return string Image URL.
+     *
      * @see http://glide.thephpleague.com/1.0/api/quick-reference/
      */
     public function url($path, array $params = [])

tests/TestCase/Routing/Filter/GlideFilterTest.php

@@ -20,15 +20,15 @@ public function setUp()
                 'base_url' => '/images/',
                 'source' => PLUGIN_ROOT . '/test_app/webroot/upload',
                 'cache' => TMP . '/cache',
-                'response' => new CakeResponseFactory,
-            ]
+                'response' => new CakeResponseFactory(),
+            ],
         ]);
 
-        $request = new Request;
+        $request = new Request();
         $request->url = 'images/cake-logo.png';
         $request->query = ['w' => 100];
 
-        $response = new Response;
+        $response = new Response();
         $this->event = new Event(
             'Dispatcher.beforeDispatch',
             null,
@@ -45,7 +45,7 @@ public function tearDown()
 
     public function testBeforeDispatch()
     {
-        $response = (new GlideFilter)->beforeDispatch($this->event);
+        $response = (new GlideFilter())->beforeDispatch($this->event);
 
         $this->assertInstanceOf('Cake\Network\Response', $response);
         $this->assertTrue(is_callable($response->body()));
@@ -64,7 +64,7 @@ public function testSecureUrl()
 
         $this->event->data['request']->url = 'images/cake%20logo.png';
         $this->event->data['request']->query = ['w' => 100, 's' => $sig];
-        $response = (new GlideFilter)->beforeDispatch($this->event);
+        $response = (new GlideFilter())->beforeDispatch($this->event);
 
         $this->assertInstanceOf('Cake\Network\Response', $response);
     }
@@ -73,7 +73,7 @@ public function testCache()
     {
         Configure::write('Glide.cache', '+1 days');
 
-        $response = (new GlideFilter)->beforeDispatch($this->event);
+        $response = (new GlideFilter())->beforeDispatch($this->event);
         $this->assertTrue(is_dir(TMP . '/cache/cake-logo.png'));
 
         $headers = $response->header();
@@ -82,7 +82,7 @@ public function testCache()
         $this->assertTrue(isset($headers['Expires']));
 
         $this->event->data['request']->env('HTTP_IF_MODIFIED_SINCE', $headers['Last-Modified']);
-        $response = (new GlideFilter)->beforeDispatch($this->event);
+        $response = (new GlideFilter())->beforeDispatch($this->event);
         $this->assertFalse(is_callable($response->body()));
     }
 }

tests/TestCase/View/Helper/GlideHelperTest.php

@@ -14,11 +14,11 @@ public function setUp()
     {
         Configure::write('Glide', [
             'serverConfig' => [
-                'base_url' => '/images/'
+                'base_url' => '/images/',
             ],
         ]);
 
-        $this->request = new Request;
+        $this->request = new Request();
         $this->request->webroot = '/';
         $this->view = new View($this->request);
         $this->helper = new GlideHelper($this->view);
@@ -53,8 +53,8 @@ public function testImage()
             'img' => [
                 'src' => '/images/logo.png?w=100',
                 'width' => 100,
-                'alt' => ''
-            ]
+                'alt' => '',
+            ],
         ], $result);
 
         $this->helper->request->webroot = '/subfolder/';
@@ -63,8 +63,8 @@ public function testImage()
             'img' => [
                 'src' => '/subfolder/images/logo.png?w=100',
                 'width' => 100,
-                'alt' => ''
-            ]
+                'alt' => '',
+            ],
         ], $result);
     }
 }

tests/bootstrap.php

@@ -1,7 +1,7 @@
 <?php
 use Cake\Core\Plugin;
 
-/**
+/*
  * Test suite bootstrap
  *
  * This function is used to find the location of CakePHP whether CakePHP
@@ -16,7 +16,7 @@
             return $root;
         }
     } while ($root !== $lastRoot);
-    throw new Exception("Cannot find the root of the application, unable to run tests");
+    throw new Exception('Cannot find the root of the application, unable to run tests');
 };
 $root = $findRoot(__FILE__);
 unset($findRoot);