Make plugin compatible with FoC/Crud #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They made a similar solution: https://github.com/FriendsOfCake/crud/blob/master/aliases.php however I get following error ``` PHP Warning: Cannot declare class Cake\Http\Exception\NotFoundException, because the name is already in use in /var/www/apacta/vendor/friendsofcake/crud/aliases.php on line 17 PHP Stack trace: PHP 1. {main}() /var/www/apacta/vendor/phpunit/phpunit/phpunit:0 PHP 2. require() /var/www/apacta/vendor/phpunit/phpunit/phpunit:51 PHP 3. ComposerAutoloaderInitc5f18fedf80ea89a4186f61d865fa6d8::getLoader() /var/www/apacta/vendor/autoload.php:7 PHP 4. composerRequirec5f18fedf80ea89a4186f61d865fa6d8() /var/www/apacta/vendor/composer/autoload_real.php:56 PHP 5. require() /var/www/apacta/vendor/composer/autoload_real.php:66 PHP 6. class_alias() /var/www/apacta/vendor/friendsofcake/crud/aliases.php:17 ```
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=========================================
Coverage 90.41% 90.41%
Complexity 52 52
=========================================
Files 3 3
Lines 146 146
=========================================
Hits 132 132
Misses 14 14Continue to review full report at Codecov.
|
|
The aliasing is done by your's truly in Crud too :) I just forgot to add alias for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They made a similar solution: https://github.com/FriendsOfCake/crud/blob/master/aliases.php
however I get following error