Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to move cards between decks #470

Closed
MailYouLater opened this issue Jun 14, 2019 · 8 comments
Closed

Add ability to move cards between decks #470

MailYouLater opened this issue Jun 14, 2019 · 8 comments

Comments

@MailYouLater
Copy link

I'd like the ability to move card a card from one deck to another. This requires both adding the card to a deck of my choice, and removing it from the deck I'm currently viewing.

If I have a card in one deck, and decide to move it to another, I'd like to be able to do so in a more streamlined way. Currently the way I'm doing it is by tapping the card, tapping "VIEW CARD", opening the menu at the top right of the screen, tapping "Add to Deck", tapping a deck, then using the back button to return to the deck I was looking at, select the card, and tap the remove button. If I'm wanting to move several cards, this starts feeling like a lot of extra work for something that should be much simpler.

I'd like to suggest that when you select one or more cards in the deck builder, one of the options should be "Move to Deck", to remove them from the current deck and add them to another deck (currently the options are "Import Selected to Wishlist" and "Delete Selected Items"), which would open a selection dialog similar to the one used when you're viewing a card and pick "Add to Deck". Also, as a further enhancement, if there are multiple of one or more selected card in the current deck, it would be really nice if it would ask how many of each of these that you want to move to the chosen deck.

@AEFeinstein
Copy link
Owner

I understand what you're asking for from a technical perspective, but I don't understand the motivation. Why do you want to move cards between decks? And is this something that you would want to implement?

@MailYouLater
Copy link
Author

I'm fairly new to MTG overall, and most of my cards are in prebuilt decks, so (for now at least,) as I decide to tweak my decks, I'll primarily be moving cards between existing decks. Also, I think it would be nice to keep a virtual 'deck' of all the (relatively few at the moment) cards I have that aren't actually in a deck, so I can move them into a deck without having to search for and/or scan/import them. Also (once I have a few more cards) I think it would be nice to be able to let people look through the cards I have that aren't in a deck without having to bring them (i.e. to plan trades for next time we meet). If at some point I have too many not-in-use cards for a single 'deck' (is there a limit on deck size?) I figure I can separate it into smaller decks based either on how likely I think I am to be willing to trade a card, or some other attribute(s) like color, rarity, etc. ... if necessary/desired.

@AEFeinstein
Copy link
Owner

First off, welcome to MTG!

Your use case makes sense, but what you're really asking for here is inventory management, not deck management. Moving cards between decks is a hack to get pseudo-inventory management into Familiar. Most users have separate decks (i.e. Goblins, Merfolk) and moving cards between them doesn't make much sense.

Full inventory management is a more involved thing, and I don't have the time to write it these days. I would highly recommend http://deckbox.org/. I don't know if the have an app or mobile interface, but it does pretty much what you want to do. You can also trade over physical mail if you trust people.

@MailYouLater
Copy link
Author

MailYouLater commented Jun 17, 2019

Well, the feature would be very useful for me, especially now while I have very few cards not in decks. At this point, literally just about any change I make to a deck is literally moving a card from one of my decks to another, and it would be nice if the app I use allowed me to do this too. Actually, unlike many MTG players, I don't really plan on having a bunch of loose cards, so I may never have more than a deck's worth of cards that aren't in one of my decks.

Anyway, I stuck a few random cards in a deck, selected a few, then took a screenshot and edited it to make a (maybe half decent?) mockup of what it could look like, just so you know what I'm visualizing for this feature request. (Sorry about my terrible icon creation skills.)
Mockup

Unfortunately I'm not much of a developer, so I'm not sure I could properly implement the functionality myself.

Also regarding DeckBox, I intend to do my MTG deck management with my phone, it doesn't look like they have an app, I'd prefer it if my data stayed on my phone so I'm not really looking for a website, I'm also a fan of open source stuff, and I really like MTG Familiar, I just wish I could import my decks and move cards between them, also as I said earlier, I really don't plan to have enough cards that aren't in a deck to bother with. I just hope to see this and #216 implemented, and I think I should be pretty happy with MTG Familiar.

@AEFeinstein
Copy link
Owner

I understand that the feature would be very useful to you, but you have to remember that Familiar is not written for you. It's written for over 100k users, so I try to focus my limited time on features that a majority of people would use and enjoy. I'm sorry if that sounds a little harsh.

I also get that you're not much of a developer, but one of the reasons Familiar is open source is so people can implement the features they want. You're always welcome to learn more Android and customize Familiar.

Sorry that DeckBox isn't what you want. At least #216 looks to be underway.

@MailYouLater
Copy link
Author

I know it's not written for me, but I really do feel like this feature would be useful to others too.
Anyway, I hope that you'll reconsider, and/or someone with more talent than me picks this up.

Are there any resources you could point me to in case I did want to try my hand at implementing this?

@AEFeinstein
Copy link
Owner

If you're looking for generic Android resources, there are tons of guides out there, like this one from Google: https://developers.google.com/training/android/

There's no specific documentation for Familiar. Most of the functions have javadoc headers which are helpful. I'm also a decent resource, so ask questions.

@AEFeinstein
Copy link
Owner

Covered by #513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants