Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress towards Python 3.12 support #2

Merged
merged 3 commits into from
May 3, 2024
Merged

Progress towards Python 3.12 support #2

merged 3 commits into from
May 3, 2024

Conversation

SergeiOssokine
Copy link
Collaborator

Python 3.12 brings some forced deprecation:

  • imp module is gone
  • numpy.distutils is gone
    Fortunately we only used the former to locate Numeric which at this point we can assume will not be used (long live numpy). For the latter we just needed to get the numpy includes.

Note that pyseobnr upstream is blocked by numba compatibility issues

@SimonMaenaut
Copy link

Dear developers,
Is there anything I could help with to get this branch merged for a new release?
Since the issues with numba are resolved, I was able to use this branch.
However a new pipy release with this fix would be great.
Kind regards, Simon

@raffienficiaud
Copy link
Contributor

Hi @SimonMaenaut and @SergeiOssokine , please give me a couple of days and I look into this.

Copy link

github-actions bot commented May 3, 2024

Unit Test Results

5 files  5 suites   0s ⏱️
1 tests 1 ✔️ 0 💤 0
5 runs  5 ✔️ 0 💤 0

Results for commit 8c1260a.

♻️ This comment has been updated with latest results.

@raffienficiaud
Copy link
Contributor

@SimonMaenaut I added compilation checks for all supported versions of python and it seems to work ok. Would you please give a try on the current branch?

Copy link
Contributor

@raffienficiaud raffienficiaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raffienficiaud raffienficiaud merged commit 0e1d9a2 into master May 3, 2024
7 checks passed
@raffienficiaud raffienficiaud deleted the python312 branch May 3, 2024 15:08
@SimonMaenaut
Copy link

@raffienficiaud Thank you for resolving this so quickly!

Since there is already a new release, I installed it from pipy through pip and everything works for me as expected.

@raffienficiaud
Copy link
Contributor

@SimonMaenaut perfect and thanks for the feedback. All the credit goes to @SergeiOssokine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants