Found and fixed the potential error in .travis.yml #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems the coverage calculates the whole virtualenv django python files, while it should only count the project files.
Update .travis.yml
It seems the coverage calculates the whole virtualenv django python files, while it should only count the project files. (reverted from commit 9711984)
|
@ventilooo t'a une idée pourquoi y'a tant de fichiers modifié alors que j'ai rien touché depuis le PR #35 ? Ça me fend le cerveau ce matin 😆 |
|
Tu as fail ta branche ! Ya des commit d'autre PR ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title says it all,
In .travis.yml, on the line env/bin/coverage run [...] add --omit=virtualenv,.virtualenv,env
Becoming :
And it feels weird that my branch didn't change at all, and still isn't identical to the develop branch on AESSUQAM... even though i PR like 4 hours ago. 💭