Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing fee estimation calculation interface #3558

Merged
merged 9 commits into from
May 21, 2024

Conversation

eanzhao
Copy link
Contributor

@eanzhao eanzhao commented May 20, 2024

  • Optimize fee estimate calculation interface
  • Add test cases

Issue: #3511

Copy link

vizipi bot commented May 20, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00% jason-hoopox 45 9
100.00% ssun0121 24 9
88.89% EanCuznaivy 56 8
77.78% ZhangXin 26 7
44.44% gldeng 7 4
44.44% zhifenglee-portkey 1 4

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
protobuf/token_contract.proto50.00%1 out of 2 times
contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs50.00%1 out of 2 times
...test/AElf.Contracts.MultiToken.Tests/BVT/TokenApplication50.00%1 out of 2 times
contract/AElf.Contracts.MultiToken/TokenContractState.cs50.00%1 out of 2 times
contract/AElf.Contracts.Profit/ProfitContract.cs50.00%1 out of 2 times

Committed file ranks

(click to expand)
  • 99.80%[...test/AElf.WebApp.Application.Chain.Tests/BlockChainAppSer]
  • 77.52%[...test/AElf.Kernel.SmartContract.ExecutionPluginForMethodFe]
  • 94.19%[...test/AElf.Kernel.SmartContract.ExecutionPluginForResource]
  • 79.63%[...src/AElf.WebApp.Application.Chain/Dto/CalculateTransactio]
  • 96.90%[...test/AElf.Kernel.SmartContract.ExecutionPluginForMethodFe]
  • 74.47%[...test/AElf.Kernel.FeeCalculation.Tests/Infrastructure/Calc]
  • 74.47%[...src/AElf.Kernel.FeeCalculation/Extensions/TransactionResu]
  • 92.13%[...test/AElf.Kernel.SmartContract.ExecutionPluginForMethodFe]
  • 86.18%[...src/AElf.WebApp.Application.Chain/Services/TransactionApp]
  • Copy link

    codecov bot commented May 20, 2024

    Codecov Report

    Attention: Patch coverage is 89.65517% with 3 lines in your changes are missing coverage. Please review.

    Project coverage is 90.73%. Comparing base (c2f2e7f) to head (b77faac).

    Additional details and impacted files

    Impacted file tree graph

    @@             Coverage Diff             @@
    ##              dev    #3558       +/-   ##
    ===========================================
    + Coverage   79.02%   90.73%   +11.71%     
    ===========================================
      Files         668      668               
      Lines       25860    25883       +23     
      Branches     2323     2325        +2     
    ===========================================
    + Hits        20436    23486     +3050     
    + Misses       5247     2281     -2966     
    + Partials      177      116       -61     
    Files Coverage Δ
    ...culation/Extensions/TransactionResultExtensions.cs 96.29% <92.30%> (+1.55%) ⬆️
    ...pplication.Chain/Services/TransactionAppService.cs 94.59% <87.50%> (+94.59%) ⬆️

    ... and 132 files with indirect coverage changes

    @vizipi vizipi bot requested a review from jason-hoopox May 21, 2024 09:56
    @eanzhao eanzhao merged commit 9ff35c0 into dev May 21, 2024
    13 checks passed
    @delete-merged-branch delete-merged-branch bot deleted the feature/optimize-fee-interface branch May 21, 2024 13:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    4 participants