Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When locking is disabled, CachedOnDiskCorpus will fail if a file already exists for a testcase #2100

Open
s1341 opened this issue Apr 25, 2024 · 0 comments
Open

When locking is disabled, CachedOnDiskCorpus will fail if a file already exists for a testcase #2100

s1341 opened this issue Apr 25, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@s1341
Copy link
Collaborator

s1341 commented Apr 25, 2024

When the locking functionality is disabled, CachedOnDiskCorpus just uses the input hash as the testcase name. If the file already exists though, the write_file_atomic will fail killing the fuzzer.

This shouldn't happen. If the file already exists, we should simply not write it. If you are worried about hash collisions, don't disable the locking functionality.
@s1341 s1341 added the bug Something isn't working label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s1341