Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eco fuzz fix #1253

Merged
merged 6 commits into from
May 9, 2023
Merged

Eco fuzz fix #1253

merged 6 commits into from
May 9, 2023

Conversation

tokatoka
Copy link
Member

@tokatoka tokatoka commented May 4, 2023

let mut average_cost = (state.corpus().count() / state.executions()) as u64;
should be
let mut average_cost = (state.executions() / state.corpus().count()) as u64;
no?

@andreafioraldi
Copy link
Member

it seems yes, or maybe it needs to be a f64 type, have you checked the original code?

@tokatoka
Copy link
Member Author

tokatoka commented May 4, 2023

@andreafioraldi
Copy link
Member

yes it is let mut average_cost = (state.executions() / state.corpus().count()) as u64;

@tokatoka
Copy link
Member Author

tokatoka commented May 4, 2023

but that's only the initial computation.
later it becomes like a derivative i.e. Δ(executions)/Δ(corpus)

@tokatoka
Copy link
Member Author

tokatoka commented May 4, 2023

i'll check other codes too

@tokatoka
Copy link
Member Author

tokatoka commented May 4, 2023

I pushed more fixes

  • change how regret is computed
  • negate was_fuzzed

@tokatoka
Copy link
Member Author

tokatoka commented May 5, 2023

fixed bunches of other issues too,
please check @andreafioraldi

for id in state.corpus().ids() {
let was_fuzzed = state.testcase(id)?.scheduled_count() > 0;
if was_fuzzed {
if !was_fuzzed {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok makes more sense, i coded it in one day

@tokatoka tokatoka merged commit fe8c06d into main May 9, 2023
12 of 15 checks passed
@tokatoka tokatoka deleted the eco_fi branch May 9, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants