Insert into corpus if feedback is_interesting on crash/timeout #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenukk
reviewed
Jun 28, 2023
| event_mgr | ||
| .fire( | ||
| state, | ||
| Event::NewTestcase { |
There was a problem hiding this comment.
The main issue is that this could make your fuzzer sloooow, but it's the right thing to do afaik, anyway :)
|
Should we maybe not add it as testcase if it's already a solution? |
|
I see you merged without the changes you suggested.... do you want me to make a separate PR? |
|
Maybe, what do you think? |
Merged
tokatoka
added a commit
that referenced
this pull request
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to enable things like crash-exploration, as well as making sure that crashes that are interesting get added to the corpus