Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ForkserverExecutor: stop forked children on exit #1493

Merged
merged 4 commits into from
Aug 31, 2023
Merged

ForkserverExecutor: stop forked children on exit #1493

merged 4 commits into from
Aug 31, 2023

Conversation

domenukk
Copy link
Member

The forkserver did not kill the child on exit.
This adds a Drop implementation.

@domenukk domenukk requested a review from tokatoka August 31, 2023 19:06
tokatoka
tokatoka approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@tokatoka tokatoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 👍

@domenukk domenukk changed the title Forkserver fix ForkserverExecutor: stop forked children on exit Aug 31, 2023
@domenukk domenukk merged commit 134fe6a into main Aug 31, 2023
17 checks passed
@domenukk domenukk deleted the forkserver_fix branch August 31, 2023 20:51
@domenukk
Copy link
Member Author

domenukk commented Sep 4, 2023

nice catch 👍

caught by @mvanotti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokatoka tokatoka tokatoka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@domenukk @tokatoka @mvanotti