Fix incorrect imports

[wtdcode]

According to https://doc.rust-lang.org/core/simd/trait.SimdOrd.html , the correct import seems core::simd::SimdOrd.

0.11.2 breaks several downstream project buildings. Currently, I'm setting =0.11.1 as workaround.

[wtdcode]

cc @tokatoka

[tokatoka]

it got updated early this month
https://doc.rust-lang.org/nightly/core/simd/cmp/trait.SimdOrd.html
can you make sure you are using the latest nightly?

[wtdcode]

it got updated early this month https://doc.rust-lang.org/nightly/core/simd/cmp/trait.SimdOrd.html can you make sure you are using the latest nightly?

I'm not sure if I understand cargo toolchains correctly. If my project use a stable toolchain while my dependencies use nightly, the code should be compiled with my stable toolchain?

Just found a quick pointer: fuzzland/ityfuzz#412

See logs: https://github.com/fuzzland/ityfuzz/actions/runs/7304832850/job/19907590056#step:8:416

[wtdcode]

Even it got updated, using core::simd::prelude::... should work for both versions according to the document links above.

[tokatoka]

I'm not sure if I understand cargo toolchains correctly. If my project use a stable toolchain while my dependencies use nightly, the code should be compiled with my stable toolchain?

this is strange. if you are using stable, this simd stuff won't be compiled
because it's guarded by #[rustversion::nightly]

[tokatoka]

Even it got updated, using core::simd::prelude::... should work for both versions according to the document links above.

ok

[wtdcode]

I'm not sure if I understand cargo toolchains correctly. If my project use a stable toolchain while my dependencies use nightly, the code should be compiled with my stable toolchain?

this is strange. if you are using stable, this simd stuff won't be compiled because it's guarded by #[rustversion::nightly]

Oh I see the actual problem. My project (and ityfuzz above) uses a slightly outdated nightly toolchain.

But anyway, the slight change in this PR should make it compatible with a wider range of nightly toolchains.

[wtdcode]

I could give a minimal example:

.
├── Cargo.lock
├── Cargo.toml
├── Dockerfile
├── rust-toolchain.toml
├── src
│   └── main.rs

Then main.rs:

use libafl::feedbacks::ConstFeedback;
fn main() {
    let f = ConstFeedback::True;
    println!("Hello, world {}!", libafl_bolts::current_nanos());
}

Cargo.toml:

[package]
name = "hello"
version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
libafl = "=0.11.2"
libafl_bolts = "=0.11.2"

rust-toolchain.toml

[toolchain]
channel = "nightly-2023-11-01"

Dockerfile

FROM rust:bookworm

WORKDIR /work

COPY Cargo.toml .
COPY src ./src
COPY rust-toolchain.toml .

RUN cargo build --release

Then docker build . gives:

30.00 error[E0432]: unresolved import `core::simd::cmp`
30.00  --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/libafl-0.11.2/src/feedbacks/map.rs:8:17
30.00   |
30.00 8 | use core::simd::cmp::SimdOrd;
30.00   |                 ^^^ could not find `cmp` in `simd`
30.00 
30.64 error[E0599]: no associated item named `LEN` found for struct `Simd` in the current scope
30.64    --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/libafl-0.11.2/src/feedbacks/map.rs:550:40
30.64     |
30.64 550 |         let steps = size / VectorType::LEN;
30.64     |                                        ^^^ associated item not found in `Simd<u8, 16>`
30.64 
30.64 error[E0599]: no associated item named `LEN` found for struct `Simd` in the current scope
30.64    --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/libafl-0.11.2/src/feedbacks/map.rs:551:39
30.64     |
30.64 551 |         let left = size % VectorType::LEN;
30.64     |                                       ^^^ associated item not found in `Simd<u8, 16>`
30.64 
30.64 error[E0599]: no associated item named `LEN` found for struct `Simd` in the current scope
30.64    --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/libafl-0.11.2/src/feedbacks/map.rs:556:44
30.64     |
30.64 556 |                 let i = step * VectorType::LEN;
30.64     |                                            ^^^ associated item not found in `Simd<u8, 16>`
30.64 
30.64 error[E0599]: no method named `simd_max` found for struct `Simd` in the current scope
30.64    --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/libafl-0.11.2/src/feedbacks/map.rs:560:26
30.64     |
30.64 560 |                 if items.simd_max(history) != history {
30.64     |                          ^^^^^^^^ method not found in `Simd<u8, 16>`
30.64    --> /rustc/9d83ac217957eece2189eccf4a7232caec7232ee/library/core/src/../../portable-simd/crates/core_simd/src/ord.rs:28:8
30.64     |
30.64     = note: the method is available for `Simd<u8, 16>` here
30.64     |
30.64     = help: items from traits can only be used if the trait is in scope
30.64 help: the following trait is implemented but not in scope; perhaps add a `use` for it:
30.64     |
30.64 3   + use core::simd::SimdOrd;
30.64     |
30.64 
30.64 error[E0599]: no associated item named `LEN` found for struct `Simd` in the current scope
30.64    --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/libafl-0.11.2/src/feedbacks/map.rs:563:54
30.64     |
30.64 563 |                         for j in i..(i + VectorType::LEN) {
30.64     |                                                      ^^^ associated item not found in `Simd<u8, 16>`
30.64 
30.64 error[E0599]: no associated item named `LEN` found for struct `Simd` in the current scope
30.64    --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/libafl-0.11.2/src/feedbacks/map.rs:584:44
30.64     |
30.64 584 |                 let i = step * VectorType::LEN;
30.64     |                                            ^^^ associated item not found in `Simd<u8, 16>`
30.64 
30.64 error[E0599]: no method named `simd_max` found for struct `Simd` in the current scope
30.64    --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/libafl-0.11.2/src/feedbacks/map.rs:588:26
30.64     |
30.64 588 |                 if items.simd_max(history) != history {
30.64     |                          ^^^^^^^^ method not found in `Simd<u8, 16>`
30.64    --> /rustc/9d83ac217957eece2189eccf4a7232caec7232ee/library/core/src/../../portable-simd/crates/core_simd/src/ord.rs:28:8
30.64     |
30.64     = note: the method is available for `Simd<u8, 16>` here
30.64     |
30.64     = help: items from traits can only be used if the trait is in scope
30.64 help: the following trait is implemented but not in scope; perhaps add a `use` for it:
30.64     |
30.64 3   + use core::simd::SimdOrd;
30.64     |
30.64 
31.10 Some errors have detailed explanations: E0432, E0599.
31.10 For more information about an error, try `rustc --explain E0432`.
31.12 error: could not compile `libafl` (lib) due to 8 previous errors
------
Dockerfile:9
--------------------
   7 |     COPY rust-toolchain.toml .
   8 |     
   9 | >>> RUN cargo build --release
--------------------
ERROR: failed to solve: process "/bin/sh -c cargo build --release" did not complete successfully: exit code: 101

[tokatoka]

https://github.com/AFLplusplus/LibAFL/blob/main/Dockerfile#L24

to fix ci
can you change this file to use llvm 16?

[wtdcode]

https://github.com/AFLplusplus/LibAFL/blob/main/Dockerfile#L24

to fix ci can you change this file to use llvm 16?

This looks like a bug in LLVM side.

e.g.:

mio@lazymbp16 /tmp> curl -I https://apt.llvm.org/bookworm
HTTP/2 404
server: nginx/1.18.0 (Ubuntu)
content-type: text/html
accept-ranges: bytes
date: Sat, 23 Dec 2023 14:05:40 GMT
via: 1.1 varnish
age: 1481
x-served-by: cache-bur-kbur8200167-BUR
x-cache: HIT
x-cache-hits: 1
x-timer: S1703340340.205043,VS0,VE0
strict-transport-security: max-age=300
content-length: 162

mio@lazymbp16 /tmp> curl -I https://apt.llvm.org/bookworm/
HTTP/2 200
server: nginx/1.18.0 (Ubuntu)
content-type: text/html
accept-ranges: bytes
date: Sat, 23 Dec 2023 14:05:42 GMT
via: 1.1 varnish
age: 1446
x-served-by: cache-bur-kbur8200081-BUR
x-cache: HIT
x-cache-hits: 1
x-timer: S1703340342.390855,VS0,VE1
strict-transport-security: max-age=300
content-length: 592

[domenukk]

@tokatoka @wtdcode this broke CI!

0.980 + exit 2
0.980 Distribution 'debian' in version '12 (bookworm)' is not supported by this script.
------
Dockerfile:24
--------------------
  22 |     # Install clang 11, common build tools
  23 |     RUN apt update && apt install -y build-essential gdb git wget python3-venv ninja-build lsb-release software-properties-common gnupg
  24 | >>> RUN wget https://apt.llvm.org/llvm.sh && chmod +x llvm.sh && ./llvm.sh 16
  25 |     
  26 |     # Copy a dummy.rs and Cargo.toml first, so that dependencies are cached
--------------------
ERROR: failed to solve: process "/bin/sh -c wget https://apt.llvm.org/llvm.sh && chmod +x llvm.sh && ./llvm.sh 16" did not complete successfully: exit code: 2

Guess we got to update the docker?

[wtdcode]

@domenukk This is LLVM website issue and I have sent it to them.

[tokatoka]

fixed now