Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken closure hooks in libafl_qemu #1839

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Fix broken closure hooks in libafl_qemu #1839

merged 4 commits into from
Feb 7, 2024

Conversation

andreafioraldi
Copy link
Member

No description provided.

@andreafioraldi andreafioraldi changed the title Fix broken crash hook Fix broken closure hooks in libafl_qemu Feb 7, 2024
@andreafioraldi
Copy link
Member Author

andreafioraldi commented Feb 7, 2024

This reverts #1825 as this PR broke closures hooks when non in main() and change the hooks to fix the original problem too. @rbran can you check if you are able to trigger the 4 hooks problem now?

@rbran
Copy link
Contributor

rbran commented Feb 7, 2024

This reverts #1825 as this PR broke closures hooks when non in main() and change the hooks to fix the original problem too. @rbran can you check if you are able to trigger the 4 hooks problem now?

Yes, the value is never moved during the vector relocation.

BTW now that the box is more complex, you may want to consider making it a Pin<Box<T>> to make sure this value is never moved.

@andreafioraldi
Copy link
Member Author

BTW now that the box is more complex, you may want to consider making it a Pin<Box<T>> to make sure this value is never moved.

The box contains fixed size data and it is never moved, it is ok, but I'll do it to avoid breaking changes in the future, even if the references passed around can be swapped in theory breaking pin

@andreafioraldi andreafioraldi merged commit 41d24ca into main Feb 7, 2024
26 checks passed
@andreafioraldi andreafioraldi deleted the qemu_link branch February 7, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants