Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libafl_nyx to newest qemu-nyx and nyx-packer #2070

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

GanbaruTobi
Copy link
Collaborator

Fixing some problems with build_nyx_support.sh.
Providing Makefile for bug in qemu-nyx

!!Did not test on Ubuntu!! Hope somebody will !
Since packer is made for Ubuntu I had to test with modifications which are not part of the commit. But the fuzzers did run.

Still known bug:
The used qemu-nyx cpu is hardcoded in the dependency libnyx. But the cpu should be changed depending on if kvm-nyx is available or not. (But its working anyway)

…lems with build_nyx_support.sh. Providing Makefile for bug in qemu-nyx
@GanbaruTobi
Copy link
Collaborator Author

This contains a change of dependency from https://github.com/syheliel/packer to https://github.com/nyx-fuzz/packer.
I don't know if there was any special feature in syheliel's version, but the nyx-fuzz seems to be more recent and will also be hold in sync with qemu-nyx.

@domenukk domenukk requested a review from syheliel April 18, 2024 13:22
@syheliel
Copy link
Collaborator

@GanbaruTobi
Copy link
Collaborator Author

I don't understand the errors and I think they are unrelated to my changes? Or maybe point me to what is the format error?

@syheliel
Copy link
Collaborator

@GanbaruTobi I retriggered CI

Copy link
Collaborator

@syheliel syheliel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domenukk domenukk merged commit d7ac802 into AFLplusplus:main Apr 19, 2024
78 checks passed
@domenukk
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants