Fixing the inconsistency btw #2012 and #2066 #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenukk
reviewed
Apr 18, 2024
| @@ -86,7 +86,7 @@ struct Opt { | |||
|
|
|||
| #[allow(clippy::similar_names)] | |||
| pub fn main() { | |||
| const MAP_SIZE: usize = EDGES_MAP_SIZE; //65536; | |||
| const MAP_SIZE: usize = EDGES_MAP_SIZE_IN_USE; //65536; | |||
There was a problem hiding this comment.
Do we not support variable map sizes in libafl_cc forkserver yet?
AFL++ collision free coverage at least can do that
There was a problem hiding this comment.
we do support but it is up to the harness if it uses it.
There was a problem hiding this comment.
When I try to set it to the 64K, it fails with:
thread 'main' panicked at /home/user/LibAFL/libafl/src/executors/forkserver.rs:765:13:
assertion failed: self.map_size.is_none() || map_size as usize <= self.map_size.unwrap()
I'm not sure why is this logic there, so I did not want to mess with it
There was a problem hiding this comment.
i fixed it in another PR already.
|
Thank you! I'll rebase #2073 on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an inconsistency between two recent PRs #2012 and #2066. This one fixes it.