Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce AFL_EXIT_ON_SEED_ISSUES #2085

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Introduce AFL_EXIT_ON_SEED_ISSUES #2085

merged 5 commits into from
Apr 23, 2024

Conversation

R9295
Copy link
Contributor

@R9295 R9295 commented Apr 20, 2024

Implements and closes #2067

@@ -322,6 +322,8 @@ pub enum Error {
OsError(io::Error, String, ErrorBacktrace),
/// Something else happened
Unknown(String, ErrorBacktrace),
// Error with the corpora
CorpusError(String, ErrorBacktrace),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just name this Corpus or CorpusInvalid - Error is redundant.
Ideally we would map the error to one of the other errors but I'm not sure if one of them applies (maybe IllegalState?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO IllegalState seems more appropriate for when an invalid action is performed by the user or if external sources modified the items the state depends on (eg. deleting the corpus entry while the fuzzer is running leading to inaccessible corpus entry). Though we could keep it IllegalState for simplicity?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe InvalidCorpus?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes more sense.

@R9295
Copy link
Contributor Author

R9295 commented Apr 22, 2024

Whoops, I accidentally force pushed.

@domenukk
Copy link
Member

Can you git checkout 4676008 and force push that again? :D

@R9295 R9295 reopened this Apr 22, 2024
libafl/src/state/mod.rs Outdated Show resolved Hide resolved
@domenukk
Copy link
Member

Will merge once CI is green :)

Add documentation to LoadConfig struct
fix nostd for LoadConfig
@domenukk domenukk merged commit 76a95bc into AFLplusplus:main Apr 23, 2024
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce AFL_EXIT_ON_SEED_ISSUES for LibAFL
2 participants