Fix #1932 #2089
Merged
Fix #1932 #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenukk
reviewed
Apr 22, 2024
| @@ -140,7 +140,7 @@ unsafe fn fuzz(options: &FuzzerOptions) -> Result<(), Error> { | |||
| // RNG | |||
| StdRand::with_seed(current_nanos()), | |||
| // Corpus that will be evolved, we keep it in memory for performance | |||
| CachedOnDiskCorpus::no_meta(PathBuf::from("./corpus_discovered"), 64) | |||
| CachedOnDiskCorpus::no_meta(PathBuf::from("./corpus_discovered"), 4) | |||
There was a problem hiding this comment.
For an example fuzzer this might be a bit small?
There was a problem hiding this comment.
yeah that was for debugging
i forgot to remove
domenukk
reviewed
Apr 22, 2024
| @@ -125,14 +119,14 @@ where | |||
| #[inline] | |||
| fn get(&self, idx: CorpusId) -> Result<&RefCell<Testcase<I>>, Error> { | |||
| let testcase = { self.inner.get(idx)? }; | |||
| self.cache_testcase(testcase, idx, false)?; | |||
| self.cache_testcase(testcase, idx)?; | |||
| Ok(testcase) | |||
| } | |||
| /// Get by id; considers both enabled and disabled testcases | |||
| #[inline] | |||
| fn get_from_all(&self, idx: CorpusId) -> Result<&RefCell<Testcase<Self::Input>>, Error> { | |||
There was a problem hiding this comment.
Should we even cache if the testcase is disabled? I don't know if we usually want that, it should be used way less?
|
@R9295 FYI, the disabled testcases crashed the fuzzer for CachedOnDiskCorpus |
|
@domenukk Oh, my bad. If I understood it correctly, it is because the disabled entry may be considered as enabled when the fuzzer restarts and the state is not serialized? |
|
no it's unrelated. see the end of #1932 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.