Making CommandExecutor generic on the specific Input #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riesentoaster
force-pushed
the
generic_commandexecutor
branch
from
712bec0
to
2de4fa1
Compare
riesentoaster
force-pushed
the
generic_commandexecutor
branch
from
2de4fa1
to
694011c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a complex
Inputand would like to map the struct's field to different parts of a command (multiple args, stdin, etc.). To be able to do this,CommandExecutorshould be generic in the specificInputused in the fuzzer. With the current version,CommandExecutors can basically only ever be used withBytesInput, since only the bytes are accessible (via the constraint onHasTargetBytes). With these changes, all exposed data from theInputstruct is available in the implementation.This is just what I came up with, it may still have room for improvement.