Add remove_from_all method to Corpus trait
#2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@R9295 Can you check this? |
|
Looks like the LibfuzzerCorpus & ArtifactCorpus also need remove_from_all implementations. LGTM otherwise |
domenukk
reviewed
May 29, 2024
libafl/src/corpus/cached.rs
Outdated
| @@ -115,6 +115,13 @@ where | |||
| Ok(testcase) | |||
| } | |||
|
|
|||
| /// Removes an entry from the corpus, returning it if it was present; considers both enabled and disabled testcases. | |||
| fn remove_from_all(&mut self, idx: CorpusId) -> Result<Testcase<Self::Input>, Error> { | |||
There was a problem hiding this comment.
Shouldn't remove just remove from wherever? Why does it make a difference if the testcase is disabled or not?
There was a problem hiding this comment.
every thing without all does not touch disabled entry
There was a problem hiding this comment.
IMHO remove should remove, no matter what
There was a problem hiding this comment.
Like, ask yourself: Why would you ever not use the remove_from_all method? How would you end up with a valid CorpusId that you don't want to remove just because it's disabled?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.