fix WeightedScheduler reporting incorrect queue cylces #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R9295
commented
Jun 6, 2024
|
|
||
| // TODO deal with corpus_counts decreasing due to removals | ||
| if current_cycles >= corpus_counts { | ||
| if runs_in_current_cycle >= corpus_counts { | ||
| wsmeta.set_runs_current_cycle(0); |
tokatoka
reviewed
Jun 6, 2024
libafl/src/schedulers/weighted.rs
Outdated
| @@ -340,7 +340,7 @@ where | |||
| }; | |||
|
|
|||
| // Update depth | |||
| if current_cycles > corpus_counts { | |||
| if runs_in_current_cycle == corpus_counts { | |||
There was a problem hiding this comment.
i think >= is better? addison added that check because corpus_counts could actually decrease..
There was a problem hiding this comment.
what i mean is that you can get corpus_counts decreased by N so runs_in_current_cycle is not necessarily equal to corpus count but you still have to update it.
There was a problem hiding this comment.
Ah, makes sense. good catch!
|
First letter of the PR description should be uppercase in this repo ;) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WeightedScheduler would never report a complete cycle since the runs would always be set to zero before it got the chance to surpass the corpus count. This PR fixes it