Symcc runtime docsrs fix #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't really verify that this will actually fix the problem, because I have trouble getting docs.rs to build locally. if this is merged, it would be good to publish the symcc_runtime crate once again (it already has a new version number) to reflect changes on docs.rs |
|
Also: make sure to have cloned the submodule before publishing. otherwise it won't work |
|
@andreafioraldi should we merge this now, the release 0.6.1 with the proper docs soonish? There was an Android fix too |
khang06
pushed a commit
to khang06/LibAFL
that referenced
this pull request
Oct 11, 2022
* add symcc as submodule * make build script docs.rs aware * bump version of symcc_runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symcc_runtime doesn't build on docs.rs, because the worker there does not have access to the network and the build.rs script attempts to download symcc from git.
the workaround to this problem is to include symcc as a submodule which will be included in the packaged crate file, so no network access is necessary to build the symcc_runtime on docs.rs.
This does add a submodule to the repository.