Fix _LLMP_BIND_ADDR for Windows

[tokatoka]

#284
with "0.0.0.0" windows gives this error The requested address is not valid in its context. (os error 10049) when broker2broker is used.

[domenukk]

Actually, can you try :: which is INADDR6_ANY vs ::1 which, again, will only bind to loopback? Sorry 🙈

[tokatoka]

ehm, ::1 was ok, but :: doesn't work 😵

[tokatoka]

The error occurs when LlmpClient calls create_attach_to_tcp to connect to 0.0.0.0's port XYZ.
I guess we can still listen on 0.0.0.0 port XYZ as a broker, but connect to localhost's port XYZ as the client

at this line

LibAFL/libafl/src/bolts/llmp.rs

Line 2583 in bb21ab7

let mut stream = match TcpStream::connect(format!("{}:{}", _LLMP_BIND_ADDR, port)) {

[domenukk]

Aah yes this makes sense, the connect needs to be localhost, unless we connect to a remote machine!
Still we can leave the bind address on :: then we are dual stack / ipv6 ready 💪

[domenukk]

And, thinking about it, instead of format I'm pretty sure we can just pass in use a tuple here.

[tokatoka]

maybe we should fall back to ipv4 addr "0.0.0.0" when binding "::" fails?

let listener = TcpListener::bind((_LLMP_BIND_ADDR, port))?

[tokatoka]

apple is not happy with this change 🥴