added write_file_atomic against ondisk corpus races #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps it would make sense to have a |
|
Right now the code is more or less copy and pasted so definitely makes sense. Where should that go? Bolts? |
|
I'd imagine bolts file utils or something? |
|
Added |
domenukk
changed the title
|
Awesome! Will test this once it is merged. |
khang06
pushed a commit
to khang06/LibAFL
that referenced
this pull request
Oct 11, 2022
* fix ondisk corpus race condition * move metadata name to be a dotfile * note ExitKind for crashes and timeouts in inprocess executor * potential fix for windows * added write_file_atomic * no_std fixes * no_std testcase fix * typo fix, windows * clippy * more no_std testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #289 by atomically adding a lockfile before using a filename.
It appends a number to the filename in case of a collision.
Also, it first writes to a tmp file, then moves to the actual filename.
Each of them are dofiles (which should then be ignored for further processing)