Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings for windows #344

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Fix warnings for windows #344

merged 1 commit into from
Nov 3, 2021

Conversation

tokatoka
Copy link
Member

@tokatoka tokatoka commented Nov 3, 2021 •
edited

very small pr; I noticed two warnings popping up when I upgraded rust to the latest

note: the built-in attribute `allow` will be ignored, since it's applied to the macro invocation `windows::build`
 --> C:\Users\toka9\source\repos\LibAFL\libafl\build.rs:9:5
9 |     windows::build!(
  |     ^^^^^^^^^^^^^^

warning: `libafl` (build script) generated 1 warning
   Compiling frida_libpng v0.6.1 (C:\Users\toka9\source\repos\LibAFL\fuzzers\frida_libpng)
warning: unused import: `CpuContext`
  --> C:\Users\toka9\source\repos\LibAFL\libafl_frida\src\helper.rs:26:5
   |
26 |     CpuContext, ModuleDetails, ModuleMap,
   |     ^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: `libafl_frida` (lib) generated 1 warning
warning: Now compile libpng with either visual studio or msys2
    Finished release [optimized + debuginfo] target(s) in 1m 01s

@domenukk domenukk merged commit 1ecef55 into main Nov 3, 2021
@tokatoka tokatoka deleted the small_win_fix branch November 3, 2021 17:19
tokatoka
tokatoka commented Nov 3, 2021
View reviewed changes
libafl_frida/src/helper.rs
@@ -25,6 +25,10 @@ use frida_gum::{
stalker::{StalkerOutput, Transformer},
CpuContext, ModuleDetails, ModuleMap,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah forgot to delete CpuContext from this line

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open a fix pr?

khang06 pushed a commit to khang06/LibAFL that referenced this pull request Oct 11, 2022
@tokatoka
fix warnings on windows (AFLplusplus#344)
521f31a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenukk domenukk Awaiting requested review from domenukk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tokatoka @domenukk