Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented MapMaxPow2Feedback #371

Merged
merged 4 commits into from
Nov 11, 2021
Merged

implemented MapMaxPow2Feedback #371

merged 4 commits into from
Nov 11, 2021

Conversation

domenukk
Copy link
Member

@domenukk domenukk commented Nov 8, 2021

This adds a new feedback that only tracks new testcases if the edges count has at least a pow2 distance to the last

@domenukk domenukk requested a review from s1341 November 8, 2021 06:45
@andreafioraldi
Copy link
Member

Why a new feedback? You can filter in the observer, see the HitcountsMapObserver

@domenukk
Copy link
Member Author

domenukk commented Nov 8, 2021

Filtering the feedback makes sense in general, I think. I forgot the observer does this internally, and it seems counter intuitive to have an active observer - but the impl is probably more performant.
Anyway, why not have both? The feedback will work with any int type

@domenukk
Copy link
Member Author

domenukk commented Nov 8, 2021

@andreafioraldi added a OneOrFilled filter, maybe this makes some sense, at least for minimizing number of corpus entires

@andreafioraldi
Copy link
Member

@andreafioraldi added a OneOrFilled filter, maybe this makes some sense, at least for minimizing number of corpus entires

For me it's better to have in the observer, so that when the observed is serialized for LLMP is already ready and the other clients avoid to filter again

@domenukk
Copy link
Member Author

domenukk commented Nov 8, 2021

other clients might use other feedbacks and strategies. Since It shouldn't have runtime overhead if it's not being used, why not offer both?

@domenukk
Copy link
Member Author

domenukk commented Nov 9, 2021

@andreafioraldi any reason against the filters? It's flexibility and doesn't cost much (apart from adding another generic..)

@domenukk domenukk merged commit fff7cbd into main Nov 11, 2021
@domenukk domenukk deleted the pow2map branch December 9, 2021 12:56
khang06 pushed a commit to khang06/LibAFL that referenced this pull request Oct 11, 2022
* implemented MapMaxPow2Feedback

* using num-traits for qemu as well

* moved back to Num for float fun

* OneOrFilled Feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants