-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use AddVectoredExceptionHandler to register exception handlers #403
Conversation
This one depends on changes included in #391 |
Does the commit 4d082cd on this branch solves the issue for you too? @expend20 🙂
|
The stackoverflow issue is not fixed yet.
I observe double crash. |
I feel we need to handle this special case like here @domenukk for windows LibAFL/libafl/src/events/llmp.rs Line 881 in fd869ba
My dump file says the second exception STATUS_ACCESS_VIOLATION is triggered here LibAFL/libafl/src/executors/inprocess.rs Line 837 in 6229165
possibly it happens because we need to allocate stacks even after the stack mem is close to zero. but still we have no way to salvage the input that triggered the stackoverflow, unless we save as much stack memory as possible inside the crash handler. |
they allocate this size of buffer on the stack |
Good work |
…usplus#403) * add * unix fix * unsafe positions * another unsafe! * ignore * ignore * make changes back * fix * fix * fmt * exception fix * fix * bug fix * fmt * fix things messed up during merge * stack overflow fix * fix * fix * fix Co-authored-by: Andrea Fioraldi <andreafioraldi@gmail.com> Co-authored-by: Dominik Maier <domenukk@gmail.com>
resolves #372
We should not use SetUnhandledExceptionFilter, it searches through the stack for exception handler, but possibly frida Stalker breaks it.
this pr uses AddVectoredExceptionHandler instead
f58e6a0