Drcov remodelling #415
Merged
Drcov remodelling #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The question is who do we want to have as the owner of the blocks list? If it's fine that |
|
What do you think? |
|
I'm not sure it matters. Do you want to rework it to be as you said? |
|
I think it is nicer if we can make it into a helper, something like |
|
The idea is to make helper.rs as small as possible, and eventually we want to remove the main helper_ so that we can pass FridaHelperTuples instead to the executor. |
|
What would the helper do? |
|
Things in pre_exec() and post_exec() can be moved into another DrCovRuntime or DrCovHelper (just as CoverageRuntime/AsanRuntime/CmpLogRuntime) and we can setup the fuzzer to use multiple (different) runtimes together |
khang06
pushed a commit
to khang06/LibAFL
that referenced
this pull request
Oct 11, 2022
* drcov remodelling * fmt * fix Co-authored-by: tokatoka <tokazerkje@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remodels the DrCovWriter.
I'm still unhappy about the general API, @s1341 how about creating the Writer in the very beginning, adding blocks to it, and then just calling
.write(&path)on it at the end?