Fix frida-mode for debug builds, ensure it will continue to work on release builds #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elease/debug x86_64/aarch64
|
I think this should be built on release x64 and debug aarch64, release aarch64 |
|
Not sure I understand what you mean... |
|
it does not work on x64 debug build. |
|
I tested my change on x64 debug build... it works as expected. |
domenukk
reviewed
Dec 19, 2021
libafl_frida/src/executor.rs
Outdated
| #[cfg(all(not(debug_assertions), target_arch = "x86_64"))] | ||
| let stalker = Stalker::new(gum); | ||
| #[cfg(any(debug_assertions, target_arch = "aarch64"))] |
There was a problem hiding this comment.
What about non-x86, non-aarch in the future?
The previous seemed more correct
s1341
changed the title
…bafl into fix_cfg_for_frida
khang06
pushed a commit
to khang06/LibAFL
that referenced
this pull request
Oct 11, 2022
…elease builds (AFLplusplus#427) * Fix cfg directives so that we actually build on all combinations of release/debug x86_64/aarch64 * Include fuzzer for stalker purposes * Get rid of cfg on use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.