Implement max total allocation size for frida asan #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokatoka
reviewed
Dec 26, 2021
| @@ -205,6 +207,11 @@ impl Allocator { | |||
| } | |||
| let rounded_up_size = self.round_up_to_page(size) + 2 * self.page_size; | |||
|
|
|||
| if self.total_allocation_size + rounded_up_size > self.options.asan_max_total_allocation() { | |||
There was a problem hiding this comment.
Shouldn't we increment self.total_allocation_size only when we call mmap?
because if we successfully find a chunk from find_smallest_fit, we don't consume any additional memory in this alloc()
There was a problem hiding this comment.
no... we want to limit the total memory alloced per test, not the amount mmaped (subsequent tests will hardly ever mmap). I forgot to reset the total to zero when we reset the allocator.
khang06
pushed a commit
to khang06/LibAFL
that referenced
this pull request
Oct 11, 2022
…tal_allocation Implement max total allocation size for frida asan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also sets the shadow-bit options to 44 and 36 instead of 46 and 36. 46 does not work on aarch64-linux.