Reorder type parameters in the correct order

[tokatoka]

this pr sorts the type parameters

I skimmed through every impl and that was a pita 🥙

[domenukk]

I wonder if we could write a custom clippy lint for that :D

[tokatoka]

FeedbackLogic should come last, so I reverted that change.

[domenukk]

It doesn't have to be last, you just need to change the types here, too:

LibAFL/libafl/src/feedbacks/mod.rs

Line 535 in af3d321

pub type EagerAndFeedback<A, B, I, S> = CombinedFeedback<A, B, I, S, LogicEagerAnd>;

[tokatoka]

Personally I feel it is a bit ugly to have CombinedFeedback<A, B, LogicEagerAnd, I, S> 😅
either way is ok

[domenukk]

That's the price to pay for alphabetical ordering ;) We have the same situation in other places too:

LibAFL/libafl/src/feedbacks/map.rs

Line 25 in af3d321

pub type AflMapFeedback<FT, I, O, S, T> = MapFeedback<FT, I, DifferentIsNovel, O, OrReducer, S, T>;