Shadow bit #455
Shadow bit #455
Conversation
|
this pr waits for asan to be fixed |
|
so the asan error I encountered is a x64 issue... this pr itself should be ok |
|
can you test this on aarch64 please? @s1341 |
libafl_frida/src/alloc.rs
Outdated
| // max(userspace address) this is usually 0x8_0000_0000_0000 - 1 on x64 linux. | ||
| let mut userspace_max: usize = 0; | ||
| // List up all occupied memory ranges | ||
| RangeDetails::enumerate_with_prot(PageProtection::Read, &mut |details| { |
There was a problem hiding this comment.
Can we assume that all relevant regions are READable?
There was a problem hiding this comment.
no... 😄
I changed it to enumerate writable & executable regions
There was a problem hiding this comment.
surely there is a better way than copy-pasting all that code?
There was a problem hiding this comment.
do you mean using PageProtection::ReadWriteExecute instead?
but that does not work.
I need to enumerate Readable ,Writable, and Executable one by one and put them into a single Vec
There was a problem hiding this comment.
So maybe do a nested for instead of copying the code three times?
|
awesome work. We'll merge once CI is green. |
* add * debugging * remove debug code * fmt * why * writable or executable ranges * for * fmt * fix
With this pr we try every possible shadow bit and make sure it is valid (by enumerating existing memory ranges and checking they don't collide)