python setuptools have deprecated easy_install

[hexcoder-]

According to setuptools easy_install is deprecated and in fact on my current Arch Linux it is not present anymore, disabling python-mode here.
The website recommends to use pip instead of easy_install.

Sooner or later this will be a problem for other distros too...

[domenukk]

I think it's fine if we stay on setup_tools as long as upstream unicorn does it. Python2.7 has been EOLled also but is still supported. Closing for now :)

[hexcoder-]

So i need to escalate it in upstream unicorn.

[domenukk]

Feel free to do so, however my bet is, setuptools will stay around for at least another 5-10 years :)

[hexcoder-]

I don't mind for setuptools, but easy_install needs to be replaced by something else, so unicornafl can be build in current Linux distros (like Arch Linux). The problem is: it does not build right now.

[domenukk]

when running make?
Do you maybe need to pip3 install -u setuptools?

[hexcoder-]

No, I have current setuptools, but setuptools does not have easy_install anymore which is required.

[hexcoder-]

When running the build script.

[domenukk]

The build script just does an import setuptools, if you have them installed, you should be good to go, see
https://github.com/AFLplusplus/AFLplusplus/blob/d999725de217a0adf4f936954c418ad8c8c3da2a/unicorn_mode/build_unicorn_support.sh#L123

I don't see where easy_install would be explicitly used?
We can change the warning of course.

[hexcoder-]

sh test-unicorn-mode.sh:
[] starting afl++ test framework ...
[] Testing: unicorn_mode
[-] Error: Python setup-tools not found. Run 'sudo apt-get install python-setuptools'.
[] running afl-fuzz for unicorn_mode (persistent), this will take approx 25 seconds
[+] afl-fuzz is working correctly with unicorn_mode (persistent)
[] Using python binary
[-] we cannot test unicorn_mode for python because it is not present
[*] 1 test cases completed.
[-] not all test cases were executed
[+] all tests were successful :-)

[hexcoder-]

maybe it is the check in test-unicorn-mode.sh:
if $PYTHON -c "help('easy_install');" </dev/null | grep -q module ; then

[hexcoder-]

So, how to check for installed setuptools instead?

[domenukk]

like this?
https://github.com/AFLplusplus/AFLplusplus/blob/d999725de217a0adf4f936954c418ad8c8c3da2a/unicorn_mode/build_unicorn_support.sh#L123

[hexcoder-]

ok, that worked, I fixed it now.