-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Minor changes to support modern Objective-C syntax. #2688
Conversation
We should actually be looking into moving everything to modern syntax... Perhaps this PR could take that on? |
I don't think a third party can help with a pull request, can we? It might be better to land this (assuming it's good, I haven't looked) and ask in another issue. This is something I'd be happy to do if someone doesn't get to it first. |
I think I got all the object subscripting changes in this PR. |
@mattshedlick cool. I havent given it a thorough review, but will do so now knowing you think you got them all. I'll try and do an audit as well. |
I ran the modern objective-c conversion tool, and ended up with this commit: Any thoughts on that? Note I ran it on top of you commit, so your changes won't show up in that diff. |
I noticed an error from the upgrade tool and commented on it; it changed an action to a read only property. |
I've made those small updates called out on that commit. It looks like the conversion tool added |
Alright, 67fb333 now has been squashed down to contain all the changes on top of @mattshedlick's commit. |
Minor changes to support modern Objective-C syntax.
All tests pass locally. Thanks for the pr! 🍻 |
4.NSArray +arrayWithObject[x] -> @[x]