This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2744, I have removed certificate chain validation as a feature in
AFSecurityPolicy
. After a community discussion as well as a conversation with the security team at Apple, there are no specific advantages to maintaining this feature going forward.Starting with this pull request, a security policy will allow a server trust if any of the pinned certificates meeting the security requirements of the policy.
In addition, I have completely refactored the security policy tests, and grouped them in a way that is more readable and more maintainable going forward. I would love some eyes on those tests and see if we can come up with any more, especially negative test cases.
We'll get this in first, then move on to bringing in public key hash pinning.