Added missing __nullable attributes to failure blocks in `AFHTTPRequestOperationManager` and `AFHTTPSessionManager` #3057

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@chuganzy
Contributor

chuganzy commented Oct 14, 2015

as titled

@kcharwood

This comment has been minimized.

Show comment
Hide comment
@kcharwood

kcharwood Oct 15, 2015

Contributor

Hi @hoppenichu. Under what conditions do you see those come back as nil? I'd like to add tests if possible, and make sure the documentation is up to date.

Contributor

kcharwood commented Oct 15, 2015

Hi @hoppenichu. Under what conditions do you see those come back as nil? I'd like to add tests if possible, and make sure the documentation is up to date.

@chuganzy

This comment has been minimized.

Show comment
Hide comment
Contributor

chuganzy commented Oct 15, 2015

@kcharwood

This comment has been minimized.

Show comment
Hide comment
@kcharwood

kcharwood Oct 15, 2015

Contributor

Ah you're right! I totally missed that looking over that code. I'll get this patch in!

Thanks 🍻

Contributor

kcharwood commented Oct 15, 2015

Ah you're right! I totally missed that looking over that code. I'll get this patch in!

Thanks 🍻

@kcharwood kcharwood modified the milestones: 2.6.1, 2.6.2 Oct 15, 2015

kcharwood added a commit that referenced this pull request Oct 21, 2015

@kcharwood

This comment has been minimized.

Show comment
Hide comment
@kcharwood

kcharwood Oct 21, 2015

Contributor

Added unit test and merged in 2.x with c90c3da

Contributor

kcharwood commented Oct 21, 2015

Added unit test and merged in 2.x with c90c3da

kcharwood added a commit that referenced this pull request Oct 21, 2015

@kcharwood

This comment has been minimized.

Show comment
Hide comment
@kcharwood

kcharwood Oct 21, 2015

Contributor

Merged in 3.0.0 with 9200627

Contributor

kcharwood commented Oct 21, 2015

Merged in 3.0.0 with 9200627

@kcharwood

This comment has been minimized.

Show comment
Hide comment
@kcharwood

kcharwood Oct 21, 2015

Contributor

🍻

Contributor

kcharwood commented Oct 21, 2015

🍻

@kcharwood kcharwood closed this Oct 21, 2015

@chuganzy

This comment has been minimized.

Show comment
Hide comment
@chuganzy

chuganzy Oct 21, 2015

Contributor

👍

Contributor

chuganzy commented Oct 21, 2015

👍

@kcharwood kcharwood changed the title from add missing __nullable attributes to Added missing __nullable attributes to failure blocks in `AFHTTPRequestOperationManager` and `AFHTTPSessionManager` Nov 3, 2015

@kcharwood kcharwood added the fixed label Nov 3, 2015

sergiou87 added a commit to plexinc/AFNetworking that referenced this pull request Dec 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment