Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing __nullable attributes to failure blocks in `AFHTTPRequestOperationManager` and `AFHTTPSessionManager` #3057

Closed
wants to merge 2 commits into from

Conversation

@chuganzy
Copy link
Contributor

chuganzy commented Oct 14, 2015

as titled

Takeru Chuganji
@kcharwood
Copy link
Contributor

kcharwood commented Oct 15, 2015

Hi @hoppenichu. Under what conditions do you see those come back as nil? I'd like to add tests if possible, and make sure the documentation is up to date.

Takeru Chuganji
@chuganzy
Copy link
Contributor Author

chuganzy commented Oct 15, 2015

@kcharwood
Copy link
Contributor

kcharwood commented Oct 15, 2015

Ah you're right! I totally missed that looking over that code. I'll get this patch in!

Thanks 🍻

@kcharwood kcharwood modified the milestones: 2.6.1, 2.6.2 Oct 15, 2015
kcharwood added a commit that referenced this pull request Oct 21, 2015
@kcharwood
Copy link
Contributor

kcharwood commented Oct 21, 2015

Added unit test and merged in 2.x with c90c3da

kcharwood added a commit that referenced this pull request Oct 21, 2015
@kcharwood
Copy link
Contributor

kcharwood commented Oct 21, 2015

Merged in 3.0.0 with 9200627

@kcharwood
Copy link
Contributor

kcharwood commented Oct 21, 2015

🍻

@kcharwood kcharwood closed this Oct 21, 2015
@chuganzy
Copy link
Contributor Author

chuganzy commented Oct 21, 2015

👍

@kcharwood kcharwood changed the title add missing __nullable attributes Added missing __nullable attributes to failure blocks in `AFHTTPRequestOperationManager` and `AFHTTPSessionManager` Nov 3, 2015
@kcharwood kcharwood added the fixed label Nov 3, 2015
sergiou87 added a commit to plexinc/AFNetworking that referenced this pull request Dec 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.