Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Improved code base to generate fewer warnings when using stricter compiler settings #3431

Merged
merged 5 commits into from
Apr 11, 2016
Merged

Improved code base to generate fewer warnings when using stricter compiler settings #3431

merged 5 commits into from
Apr 11, 2016

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Apr 8, 2016

  • Remove most #pragma clang diagnostic ignored scattered throughout the files
  • Enable more warnings
  • Enable Treat Warnings as Errors
  • Fix code that was flagged by new warnings

@0xced
Remove all #pragma clang diagnostic ignored "-Wgnu"
16c09fa
@0xced
Remove unnecessary #pragma clang diagnostic ignored
c52ff85
@0xced
Comment out unused static functions
4a7148d 
They were referenced in testPolicyWithCertificatePinningAllowsGoogleComServerTrustIncompleteChainWithRootCertificatePinnedAndValidDomainName which is now disabled.
@0xced
Enable Treat Warnings as Errors
19e4aef
@0xced
Enable more warnings
885e0a4
@kcharwood kcharwood changed the title Improve warnings Improved code base to generate fewer warnings when using strictor compiler settings Apr 11, 2016
@kcharwood kcharwood added this to the 3.1.1 milestone Apr 11, 2016
@kcharwood kcharwood merged commit b7073e4 into AFNetworking:master Apr 11, 2016
@kcharwood kcharwood modified the milestones: 3.1.1, 3.2.0 Oct 3, 2016
@0xced 0xced changed the title Improved code base to generate fewer warnings when using strictor compiler settings Improved code base to generate fewer warnings when using stricter compiler settings Oct 11, 2016
@0xced 0xced deleted the warnings branch October 11, 2016 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
updated
Projects
None yet
Milestone
3.2.0
2 participants
@0xced @kcharwood