Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Fixed crashes due to race conditions with NSMutableDictionary access in AFHTTPRequestSerializer #3526

Merged
merged 3 commits into from
Jun 6, 2016

Commits on Mar 8, 2016

  1. Fix for crashes due to dangerous NSMutableDictionary access in AFHTTP…

    …RequestSerialiser, added a dispatch queue for safety in multithreaded environments.
    alexbird committed Mar 8, 2016
    1 Configuration menu
    Copy the full SHA
    2ffdc3d View commit details
    Browse the repository at this point in the history

Commits on May 19, 2016

  1. Fix for crashes due to dangerous NSMutableDictionary access in AFHTTP…

    …RequestSerialiser – Added unit test which reproduces the issue.
    
    NB: as the crash is caused by using a dictionary in a way that the runtime did not expect, it typically causes intermittent crashes which are almost always in unrelated areas of the app. This seems to be strongly related to deallocation of the values in the dictionary, but this may not be the only cause. As such, there is nothing to positively test for, the test succeeds if it doesn't EXC_BAD_ACCESS when cleaning up the @autoreleasepool at the end.
    alexbird committed May 19, 2016
    Configuration menu
    Copy the full SHA
    fa8b02d View commit details
    Browse the repository at this point in the history
  2. Fix for crashes due to dangerous NSMutableDictionary access in AFHTTP…

    …RequestSerialiser – Moved unit test to a better location.
    alexbird committed May 19, 2016
    Configuration menu
    Copy the full SHA
    0e46d1e View commit details
    Browse the repository at this point in the history