New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change “Mac OS X” and “OS X” references to “macOS” #4104

Merged
merged 8 commits into from Dec 15, 2017

Conversation

Projects
None yet
2 participants
@SlaunchaMan
Member

SlaunchaMan commented Nov 23, 2017

This PR:

  • Updates "OS X" and "Mac OS X" to "macOS"
  • Sets the warnings and such to Xcode 9.1 defaults.
  • Fixes some analyzer warnings about mutable copies and memory leaks.
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 23, 2017

Codecov Report

Merging #4104 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4104      +/-   ##
==========================================
- Coverage    82.8%   82.79%   -0.01%     
==========================================
  Files          46       46              
  Lines        5304     5308       +4     
  Branches      439      441       +2     
==========================================
+ Hits         4392     4395       +3     
  Misses        671      671              
- Partials      241      242       +1
Impacted Files Coverage Δ
AFNetworking/AFURLRequestSerialization.m 60.03% <100%> (+0.12%) ⬆️
Tests/Tests/AFSecurityPolicyTests.m 100% <100%> (ø) ⬆️
Tests/Tests/AFHTTPSessionManagerTests.m 98.59% <100%> (ø) ⬆️
Tests/Tests/AFHTTPRequestSerializationTests.m 100% <100%> (ø) ⬆️
AFNetworking/AFURLSessionManager.m 59.89% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d5a894...fc941b3. Read the comment docs.

codecov-io commented Nov 23, 2017

Codecov Report

Merging #4104 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4104      +/-   ##
==========================================
- Coverage    82.8%   82.79%   -0.01%     
==========================================
  Files          46       46              
  Lines        5304     5308       +4     
  Branches      439      441       +2     
==========================================
+ Hits         4392     4395       +3     
  Misses        671      671              
- Partials      241      242       +1
Impacted Files Coverage Δ
AFNetworking/AFURLRequestSerialization.m 60.03% <100%> (+0.12%) ⬆️
Tests/Tests/AFSecurityPolicyTests.m 100% <100%> (ø) ⬆️
Tests/Tests/AFHTTPSessionManagerTests.m 98.59% <100%> (ø) ⬆️
Tests/Tests/AFHTTPRequestSerializationTests.m 100% <100%> (ø) ⬆️
AFNetworking/AFURLSessionManager.m 59.89% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d5a894...fc941b3. Read the comment docs.

@SlaunchaMan SlaunchaMan merged commit f7ecca5 into AFNetworking:master Dec 15, 2017

3 checks passed

codecov/patch 100% of diff hit (target 82.8%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +17.19% compared to 9d5a894
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SlaunchaMan SlaunchaMan deleted the SlaunchaMan:2017-updates branch Dec 15, 2017

@SlaunchaMan SlaunchaMan added this to the 3.2.0 milestone Dec 15, 2017

@SlaunchaMan SlaunchaMan changed the title from 2017 Updates to Change “Mac OS X” and “OS X” references to “macOS” Dec 15, 2017

@SlaunchaMan SlaunchaMan added the changed label Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment