Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

isExpired check #90

Closed
dmishe opened this issue Oct 14, 2013 · 1 comment
Closed

isExpired check #90

dmishe opened this issue Oct 14, 2013 · 1 comment

Comments

@dmishe
Copy link

dmishe commented Oct 14, 2013

Right now token expiration is checked this way:

 [self.expiration compare:[NSDate date]] == NSOrderedDescending;

Which, if I'm not mistaken, means (expiration > now), while it should be (expiration < now) because we want to test if token expires at a date in the future?
mattt added a commit that referenced this issue Oct 23, 2013
@mattt
[Issue #90] Fixing comparison of expiration date
140f474
@mattt
Copy link
Contributor

mattt commented Oct 23, 2013

Yep. Looks like it was originally backwards with its addition in 2dca4ee. 140f474 makes that change. Thanks for pointing this out, @dmishe.

@mattt mattt closed this as completed Oct 23, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattt @dmishe