Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Removes kAFApplicationLaunchedWithURLNotification on iOS #21

Conversation

OliverLetterer
Copy link
Contributor

I removes the need to implement -[UIApplicationDelegate application:openURL:sourceApplication:annotation:] and posting the kAFApplicationLaunchedWithURLNotification notification on iOS by swizzling or implementing -[UIApplicationDelegate application:openURL:sourceApplication:annotation:] at runtime.

@yelled3
Copy link

yelled3 commented Mar 18, 2013

amazing!

@OliverLetterer
Copy link
Contributor Author

I know this adds some runtime magic with swizzling or implementing UIApplicationDelegate callbacks at runtime (yes I do love this stuff :D ) but makes the user experience for the developer on iOS a bit nicer. Any chance in seeing a merge? Or is this too much magic? /cc @mattt

@mattt
Copy link
Contributor

mattt commented Aug 21, 2013

Finally following up on this; really sorry for the wait.

This is extremely cool, but definitely too magical for my particular tastes. In particular, this approach would unnecessarily limit an application to a single client, and create ununexpected behavior if added to a project from another framework, for instance.

Short of this "just working" out-of-the-box, the best we can do is to document the behavior (see 7b214a7), and go from there.

Thanks all the same, @OliverLetterer! Nice work.

@mattt mattt closed this Aug 21, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants