Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Support for xAuth #35

Closed
wants to merge 3 commits into from
Closed

Support for xAuth #35

wants to merge 3 commits into from

Conversation

hwaxxer
Copy link

@hwaxxer hwaxxer commented Mar 28, 2013

A simple method to support xAuth. I didn't find any good general purpose xAuth libraries and think this would be a nice add-on to the best OAuth library.

@alexkarpenko
Copy link

This doesn't work for Twitter's xAuth since only x_auth_* parameters should be sent in the HTTP POST body. Patch here: midnox@9987bb6

See Twitter's docs for details: https://dev.twitter.com/docs/oauth/xauth

@hwaxxer
Copy link
Author

hwaxxer commented Apr 18, 2013

Thanks!

@alexkarpenko
Copy link

No problem! Now if only @mattt would hurry up and merge this :)

@jcouture
Copy link

I'm sure he will come around and merge this pull request soon enough. He speaks at MMConf (http://www.mmconf.com/), so he might have other things on his mind. 😄

@alexkarpenko
Copy link

Oh, I'm sure he will. Between all the projects, conferences, and NSHipster, how does he even find time to sleep?! 😄

@mattt
Copy link
Contributor

mattt commented Apr 19, 2013

Aww, you guys... 😁

It's been a while, but what is xAuth's relationship to OAuth, exactly? AFXAuthClient is a thing. Is there anything this patch accomplishes that this library doesn't? Is this the right functionality to add to an OAuth library?

Just curious, is all.

@hwaxxer
Copy link
Author

hwaxxer commented Apr 19, 2013

xAuth still needs OAuth signed requests which is why it leverages the functionality of AFOAuth1Client. But I do understand your concern. I could create a separate library, letting AFXAuthClient be a subclass of AFOAuth1Client. I think it'd be a nice edition to the AFNetworking suite as the xAuth paradigm seems to be growing in popularity (for better or worse).

@mattt mattt closed this Aug 21, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants