Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Add NSCoding support to AFOAuth1Token #37

Closed
wants to merge 4 commits into from
Closed

Add NSCoding support to AFOAuth1Token #37

wants to merge 4 commits into from

Conversation

gspiers
Copy link
Contributor

@gspiers gspiers commented Apr 25, 2013

Makes it very easy to persist the token. We are using it to encode to NSData and then store in the Keychain.

Greg Spiers added 4 commits April 25, 2013 11:30
…the operation as there might be additional data in the response, for example Flickr returns user details of the auth'd user.
@mattt
Copy link
Contributor

mattt commented May 7, 2013

Thanks so much for the patch, @gspiers. This is a great feature to have. I cherry-picked eb619ce, and replaced the string constants with literals in 3e02873 (in any case other than NSCoding, I'd use constants, but here, it's just a lot cleaner, IMO).

I also went ahead and made AFOAuth1Client NSCoding compliant as well (since AFHTTPClient is).

...which led me to adding NSCopying for each. What?

As for changing the signature of the callback blocks, this would be a significant API change that I have an alternative idea for, which will be discussed in #39. Cheers!

@gspiers
Copy link
Contributor Author

gspiers commented May 7, 2013

Thanks @mattt! Really appreciate the detailed response and #39 is exactly what I am after.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants