Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

padpo doesn't like *n*-uplet on msgstr start #58

Closed
Seluj78 opened this issue Jan 28, 2021 · 8 comments
Closed

padpo doesn't like *n*-uplet on msgstr start #58

Seluj78 opened this issue Jan 28, 2021 · 8 comments
Labels
bug Something isn't working

Comments

@Seluj78
Copy link
Contributor

Seluj78 commented Jan 28, 2021

As you can see, *n*-uplet is a valid word but padpo throws an error when it sees that word at the beginning of a translation

Screenshot 2021-01-28 at 13 33 28

Screenshot 2021-01-28 at 13 33 16

@vpoulailleau
Copy link
Member

https://github.com/AFPy/padpo/blob/master/padpo/checkers/glossary.py needs to be updated, "n-uplet" was added to https://github.com/python/python-docs-fr/blob/3.9/CONTRIBUTING.rst

The entire file needs to be updated according to the sources in comment in the Python code.

@Seluj78
Copy link
Contributor Author

Seluj78 commented Jan 28, 2021

Could you make a scrapper that auto does it ?

@vpoulailleau
Copy link
Member

vpoulailleau commented Jan 28, 2021

I thought I could do it, but it was not feasible, because the glossary is not exhaustive (plural form…). This is a manual work, but in comment in the code, there is the exact commit from which comes the data, so that we can git diff

@Seluj78
Copy link
Contributor Author

Seluj78 commented Jan 28, 2021

ah nice !

vpoulailleau added a commit to vpoulailleau/python-docs-fr that referenced this issue Feb 2, 2021
PyDocTeur pushed a commit to python/python-docs-fr that referenced this issue Feb 2, 2021
vpoulailleau added a commit to vpoulailleau/padpo that referenced this issue Feb 2, 2021
vpoulailleau added a commit to vpoulailleau/padpo that referenced this issue Feb 2, 2021
vpoulailleau added a commit to vpoulailleau/padpo that referenced this issue Feb 2, 2021
vpoulailleau added a commit to vpoulailleau/padpo that referenced this issue Feb 2, 2021
vpoulailleau added a commit to vpoulailleau/padpo that referenced this issue Feb 2, 2021
@vpoulailleau
Copy link
Member

@Seluj78 C'est quoi l'astuce pour afficher les résultats padpo directement dans la pull request ?

@Seluj78
Copy link
Contributor Author

Seluj78 commented Feb 2, 2021

@vpoulailleau aucune idée, ca l'a fait tout seul, je suppose que ton formatting l'a fait? ou alors c'est mes extensions (genre refined github) ?

@vpoulailleau
Copy link
Member

@Seluj78 Suite à une remarque de @JulienPalard, je respecte le formattage de GCC.

Je vois aussi les remarques de padpo dans la pull request. J'imagine qu'il a fallu configurer quelque chose dans le dépôt. Cela doit avoir un rapport avec https://github.com/actions/toolkit/blob/master/docs/problem-matchers.md, non ?

@Seluj78
Copy link
Contributor Author

Seluj78 commented Feb 2, 2021

Je n'ai aucune mémoire de configuration spécifique dans le répo, donc ça doit être par défaut et c'est déjà très stylé!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants